Open hansu opened 2 months ago
[Hans Unzner]
It's mostly when bold formatting is involved:
While some bold formatting were removed intentionally, the classicladder.9 ones you show seem to be unintentintional.
I could have spend more time comparing the before and after versions, but we wanted to complete the migration before the LinuxCNC developer gathering were over and decided to fix any required cleanup afterwords. Very glad to see you are able to assist in tracking down any problems. :)
-- Happy hacking Petter Reinholdtsen
The problem are strings composed of <bold><italic>[<bold>]<regular>
For example
classicladder.0.in-NN IN bit::
should be
**classicladder.0.in-**_NN_ IN bit::
but was converted like this
*classicladder.0.in-*_NN_ IN bit::
Also some asteriskes appeared before the double colon
See here the fix for the first man pages: https://github.com/LinuxCNC/linuxcnc/pull/3045/files
@petterreinholdtsen maybe we can fix this by applying an intelligent regular expression on it?
[Hans Unzner]
@petterreinholdtsen maybe we can fix this by applying an intelligent regular expression on it?
Feel free to try. I used pandoc to do the conversion, and hoped it would do a good enough job. :)
Feel free to try.
I was hoping you can help with your expertise ;-)
I used pandoc to do the conversion, and hoped it would do a good enough job. :)
It seems that pandoc has some problems with the inline formatting. Maybe you can report that?
@petterreinholdtsen I have now fixed a few man pages and I think you could also fix some.
Otherwise I tend to revert the converted man pages because the goal was to simplify the maintenance of the man pages and not to introduce a huge amount of work to fix the errorneous converted man pages.
Is this fixed now? http://linuxcnc.org/docs/stable/html/man/man9/classicladder.9.html Looks OK to me.
50% of the man9 pages are fine (double checked), the rest probably as well.
But you can't check it this way unfortunately because of https://github.com/LinuxCNC/linuxcnc/issues/3031
I think we are mostly stuck with the man pages PRs of mine still failing on sid.
Since https://github.com/LinuxCNC/linuxcnc/pull/1376 (which makes the man pages being generated from adoc sources, wich is a great improvement!) some of them have not ben converted correctly. So please do not update the man pages until they are fixed.
Here is a list of the differences of the man9 man pages:
It's mostly when bold formatting is involved:
Unfortunately due to https://github.com/LinuxCNC/linuxcnc/issues/3031 it is currently not possible to inspect the new generated man pages on the web site. You only can check this on a local build.