Closed smoe closed 1 month ago
A bit to long for me to review in one sitting, but I skimmed through it and found a few minor issues. Besides this, it look good.
[Steffen Möller]
That is where it should always be, like 1st or 2nd.
Aha. Did not know. I guess it must be in the Chicago style, as it is not in the Cambridge one, as far as I can tell. <URL: https://dictionary.cambridge.org/grammar/british-grammar/dates >.
-- Happy hacking Petter Reinholdtsen
[Steffen Möller] That is where it should always be, like 1st or 2nd. Aha. Did not know. I guess it must be in the Chicago style, as it is not in the Cambridge one, as far as I can tell. <URL: https://dictionary.cambridge.org/grammar/british-grammar/dates >. …
It is indeed optional ... https://proofed.com/writing-tips/when-to-use-superscript-and-subscript-in-your-writing/ ... just some early brainwash.
This was a timeout error in the tests.
Running test: ./tests/single-step
*** ./tests/single-step: XFAIL: test run exited with 1
************** result:
Machine configuration file is 'test.ini'
Starting LinuxCNC...
linuxcncsvr (216869) emcsvr: machine 'unknown' version '1.1'
linuxcnc TPMOD=tpmod HOMEMOD=homemod EMCMOT=motmod
milltask (216881) task: machine 'unknown' version '1.1'
emc/task/taskclass.cc 187: can't load tool table.
Found file(LIB): /usr/share/linuxcnc/hallib/core_sim.hal
USRMOT: ERROR: command 30 timeout
emcMotionInit: emcTrajInit failed
task: main loop took 0.018273 seconds
task: main loop took 0.018519 seconds
Shutting down and cleaning up LinuxCNC...
task: 0 cycles, min=0.000004, max=0.018519, avg=-1.000000, 2 latency excursions (> 10x expected cycle time of 0.001000s)
LinuxCNC terminated with an error. You can find more information in the log:
/home/testrunner/linuxcnc_debug.txt
and
/home/testrunner/linuxcnc_print.txt
as well as in the output of the shell command 'dmesg' and in the terminal
************** stderr:
+ linuxcnc -r test.ini
ERROR: ld.so: object 'libeatmydata.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
Note: Using POSIX non-realtime
ERROR: ld.so: object 'libeatmydata.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
emc/tooldata/tooldata_common.cc, 304: Failed to open tool table file 'simpockets.tbl': No such file or directory
emc/tooldata/tooldata_common.cc, 304: Failed to open tool table file 'simpockets.tbl': No such file or directory
ERROR: ld.so: object 'libeatmydata.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libeatmydata.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libeatmydata.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libeatmydata.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
link (updating variable file): No such file or directory
line=7; Xpos=5.00; Ypos=0.11; Zpos=0.00; counter=0
line=7; Xpos=5.00; Ypos=0.94; Zpos=0.00; counter=0
line=7; Xpos=5.00; Ypos=1.78; Zpos=0.00; counter=0
line=7; Xpos=5.00; Ypos=2.61; Zpos=0.00; counter=0
line=7; Xpos=5.00; Ypos=3.44; Zpos=0.00; counter=0
line=7; Xpos=5.00; Ypos=4.28; Zpos=0.00; counter=0
Taking step from X5.00 Y5.00
line=9; Xpos=5.14; Ypos=5.00; Zpos=0.00; counter=0
line=9; Xpos=5.98; Ypos=5.00; Zpos=0.00; counter=0
line=9; Xpos=6.81; Ypos=5.00; Zpos=0.00; counter=0
line=9; Xpos=7.64; Ypos=5.00; Zpos=0.00; counter=0
line=9; Xpos=8.48; Ypos=5.00; Zpos=0.00; counter=0
line=9; Xpos=9.31; Ypos=5.00; Zpos=0.00; counter=0
Taking step from X10.00 Y5.00
line=7; Xpos=10.00; Ypos=5.13; Zpos=0.00; counter=5
line=7; Xpos=10.00; Ypos=5.97; Zpos=0.00; counter=5
line=7; Xpos=10.00; Ypos=6.80; Zpos=0.00; counter=5
line=7; Xpos=10.00; Ypos=7.63; Zpos=0.00; counter=5
line=7; Xpos=10.00; Ypos=8.47; Zpos=0.00; counter=5
line=7; Xpos=10.00; Ypos=9.30; Zpos=0.00; counter=5
Taking step from X10.00 Y10.00
line=9; Xpos=10.14; Ypos=10.00; Zpos=0.00; counter=5
line=9; Xpos=10.98; Ypos=10.00; Zpos=0.00; counter=5
line=9; Xpos=11.81; Ypos=10.00; Zpos=0.00; counter=5
line=9; Xpos=12.64; Ypos=10.00; Zpos=0.00; counter=5
line=9; Xpos=13.48; Ypos=10.00; Zpos=0.00; counter=5
line=9; Xpos=14.31; Ypos=10.00; Zpos=0.00; counter=5
Taking step from X15.00 Y10.00
line=7; Xpos=15.00; Ypos=10.14; Zpos=0.00; counter=10
line=7; Xpos=15.00; Ypos=10.98; Zpos=0.00; counter=10
line=7; Xpos=15.00; Ypos=11.81; Zpos=0.00; counter=10
line=7; Xpos=15.00; Ypos=12.64; Zpos=0.00; counter=10
line=7; Xpos=15.00; Ypos=13.48; Zpos=0.00; counter=10
line=7; Xpos=15.00; Ypos=14.31; Zpos=0.00; counter=10
Taking step from X15.00 Y15.00
line=9; Xpos=15.14; Ypos=15.00; Zpos=0.00; counter=10
line=9; Xpos=15.98; Ypos=15.00; Zpos=0.00; counter=10
line=9; Xpos=16.81; Ypos=15.00; Zpos=0.00; counter=10
line=9; Xpos=17.64; Ypos=15.00; Zpos=0.00; counter=10
line=9; Xpos=18.48; Ypos=15.00; Zpos=0.00; counter=10
line=9; Xpos=19.31; Ypos=15.00; Zpos=0.00; counter=10
Taking step from X20.00 Y15.00
line=7; Xpos=20.00; Ypos=15.13; Zpos=0.00; counter=15
line=7; Xpos=20.00; Ypos=15.97; Zpos=0.00; counter=15
line=7; Xpos=20.00; Ypos=16.80; Zpos=0.00; counter=15
line=7; Xpos=20.00; Ypos=17.63; Zpos=0.00; counter=15
line=7; Xpos=20.00; Ypos=18.47; Zpos=0.00; counter=15
line=7; Xpos=20.00; Ypos=19.30; Zpos=0.00; counter=15
Taking step from X20.00 Y20.00
line=9; Xpos=20.14; Ypos=20.00; Zpos=0.00; counter=15
line=9; Xpos=20.98; Ypos=20.00; Zpos=0.00; counter=15
line=9; Xpos=21.81; Ypos=20.00; Zpos=0.00; counter=15
line=9; Xpos=22.64; Ypos=20.00; Zpos=0.00; counter=15
line=9; Xpos=23.48; Ypos=20.00; Zpos=0.00; counter=15
line=9; Xpos=24.31; Ypos=20.00; Zpos=0.00; counter=15
Taking step from X25.00 Y20.00
error: timeout in wait_complete_step(), 15.0 seconds were not enough
ERROR: ld.so: object 'libeatmydata.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libeatmydata.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libeatmydata.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libeatmydata.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libeatmydata.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libeatmydata.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libeatmydata.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
Note: Using POSIX non-realtime
Running test: ./tests/source.0
**************
I suggest to accept the PR despite this unrelated build failure. Maybe the timeout can be extended?
Seems like our CI is a bit fuzzy. Worked now and - @petterreinholdtsen or @hansu, please give it a spin.
Took a bit more than an hour to get through, but I could not find any issues I believe need to be fixed now, the change look good, and I will squash and merge it.
A bit more while translating.