LinuxCNC / linuxcnc

LinuxCNC controls CNC machines. It can drive milling machines, lathes, 3d printers, laser cutters, plasma cutters, robot arms, hexapods, and more.
http://linuxcnc.org/
GNU General Public License v2.0
1.81k stars 1.16k forks source link

[EMCIO] Remove various obsolete references to io and iov2 #3169

Closed Sigma1912 closed 1 week ago

Sigma1912 commented 2 weeks ago

This PR removes obsolete references to 'io' and 'iov2'

Background: 'io' and 'iov2' have been removed and their functionality moved to task: https://github.com/LinuxCNC/linuxcnc/commit/9d79c2aa23e6e6762dfc32b4ad7c4b7d219e9ea4

Discussion see: https://github.com/LinuxCNC/linuxcnc/pull/3167

Sigma1912 commented 2 weeks ago

Not sure why some of these tests are failing. Seems build and test just fine on my local machine.

andypugh commented 2 weeks ago

Not sure why some of these tests are failing. Seems build and test just fine on my local machine.

When I last looked it seemed to be a problem with the Ubuntu VM not finding a Firefox snap to install.

Sigma1912 commented 2 weeks ago

Thanks for the comment. It seems to have smoothed itself out now.

hansu commented 2 weeks ago

iocontrol.1.adoc can also be removed I think. But we should link iocontrol to io by adding it to the name section:

io(1)
NAME
+ io, iocontrol - interacts with HAL or G-code in non-realtime
- io - interacts with HAL or G-code in non-realtime
hansu commented 2 weeks ago

po4a.cfg:170: The master file 'src/man/man1/iocontrol.1.adoc' does not exist.

Sorry you have to remove it from the po4a.cfg as well.

Sigma1912 commented 2 weeks ago

Looking at this commit by @rene-dev makes me think that the [EMCIO] 'CYCLE_TIME = 0.100' entry should also be removed. https://github.com/LinuxCNC/linuxcnc/commit/27ef544ae7a68460731b8dd65b7d3ef678090433#diff-53c30ad3a9ebf3f0b298246f7bec4fc2599bfdad79ae2334ed89dfad9ee6f2a6L1347

rene-dev commented 2 weeks ago

Yes, emcio cycle time can be removed as well.

Sigma1912 commented 2 weeks ago

This is ready, as far as I'm concerned.