search

LinuxCNC / linuxcnc

LinuxCNC controls CNC machines. It can drive milling machines, lathes, 3d printers, laser cutters, plasma cutters, robot arms, hexapods, and more.
http://linuxcnc.org/
GNU General Public License v2.0
1.79k stars 1.15k forks source link

Increase default HAL_NAME_LEN currently 47 characters #615

Open lorenzncode opened 5 years ago

lorenzncode commented 5 years ago

This is an enhancement request, not a bug.

I'm programmatically building the signal names and using Python hal.connect(). I ran into the name is too long error e.g.: HAL: ERROR: signal name 'scopeinterface.microscope.rapid-scope-zero-link2' is too long

Here I'm building the name composed of two different component names and a pin name and it ended up greater than the max limit.

The limit appears to be defined in hal.h: HAL_NAME_LEN

The request is to increase the default to say 128 if possible.

andypugh commented 5 years ago

This would be possible, but perhaps there is some advantage on forcing a shorter limit on the signal names. They are meant to be human-readable. Is there perhaps an argument that very long names will be harder to distinguish?

Additionally, there is a risk of 128 character HAL signal names line-wrapping in the text editor, not fitting in the halshow window, etc etc.

rene-dev commented 4 years ago

I would also increase it to 128. especially on larger hal file might make things easier to read. requires some more changes, and increase in hal version number. last update was few years ago: https://github.com/LinuxCNC/linuxcnc/commit/5735855f5e3c7456299f4e16931d11d63979ecfe

andypugh commented 4 years ago

I suppose this would be one way to quiet the snprintf warnings in gcc-8. Though I would prefer to do it the right way, ie do something with the snprintf return value and warn the user of pin-name (etc) truncation.