LinuxCNC / linuxcnc

LinuxCNC controls CNC machines. It can drive milling machines, lathes, 3d printers, laser cutters, plasma cutters, robot arms, hexapods, and more.
http://linuxcnc.org/
GNU General Public License v2.0
1.78k stars 1.14k forks source link

thcud.comp #911

Closed daiman444 closed 11 months ago

daiman444 commented 4 years ago

greetings! I am using LinuxCNC 2.7.15. when the component is operating, the cutter jerks up / down when turning on / off the thc, because if (! enable) { z_pos_out = z_pos_in; z_fb_out = z_pos_in;

the amount of jerk is equal to: // Global Variables variable float offset;

this problem is persistent for the component.

the problem was solved by adding offset to z_pos_in after shutdown. it looks like this:

if (! enable) { z_pos_out = z_pos_in + offset; z_fb_out = z_pos_in; thank you for attention!

jethornton commented 4 years ago

I have no way to test this but it looks ok to me.

JT

On 7/27/20 3:52 AM, daiman444 wrote:

greetings! I am using LinuxCNC 2.7.15. when the component is operating, the cutter jerks up / down when turning on / off the thc, because if (! enable) { z_pos_out = z_pos_in; z_fb_out = z_pos_in;

the amount of jerk is equal to: // Global Variables variable float offset;

this problem is persistent for the component.

the problem was solved by adding offset to z_pos_in after shutdown. it looks like this:

if (! enable) { z_pos_out = z_pos_in + offset; z_fb_out = z_pos_in; thank you for attention!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LinuxCNC/linuxcnc/issues/911, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJTFPBQO7B3LKUHA3GSN23R5U54XANCNFSM4PIRADLQ.

petterreinholdtsen commented 11 months ago

See also #675, another issue related to thcud.

andypugh commented 11 months ago

It's been a long wait, but I just made this change. Thanks.