LinuxCNC / linuxcnc

LinuxCNC controls CNC machines. It can drive milling machines, lathes, 3d printers, laser cutters, plasma cutters, robot arms, hexapods, and more.
http://linuxcnc.org/
GNU General Public License v2.0
1.81k stars 1.16k forks source link

Possibly spurious alert for configuration update. #942

Open JetForMe opened 4 years ago

JetForMe commented 4 years ago

When this configuration has 22.222 as the [JOINT_4]SCALE value, LinuxCNC complains about the INI file version needing to be updated. If the value is set to 22, it launches without complaint.

This seems like a bug.

Here are the steps I follow to reproduce the issue:

  1. Launch linuxcnc with the above-referenced configuration

This is what I expected to happen:

It should launch.

This is what happened instead:

It pops up an alert asking me if I want to attempt to auto-update my configuration.

It worked properly before this:

I'm adding a new axis. Fractional values work for other axes.

Information about my hardware and software:

$ lsb_release -a
No LSB modules are available.
Distributor ID: Debian
Description:    Debian GNU/Linux 9.13 (stretch)
Release:    9.13
Codename:   stretch
$ uname -a
Linux router 4.9.0-13-rt-amd64 #1 SMP PREEMPT RT Debian 4.9.228-1 (2020-07-05) x86_64 GNU/Linux

1:2.9.0~pre0.2180.ga14b08a70

andypugh commented 4 years ago

I cloned your github and tried the config.

It worked up to the point that it didn't find your hardware.

Are you absolutely sure that you are doing the test that you think you are? The script only looks at [EMC]VERSION when deciding whether an update is needed:

https://github.com/LinuxCNC/linuxcnc/blob/master/scripts/linuxcnc.in#L440

JetForMe commented 4 years ago

I'm not doing any explicit test. All I know is half the time, when I make a change to a value or config parameter, and then re-launch linuxcnc, I get that alert. I'm about to try again, I'll try to post the INI that causes it.

JetForMe commented 4 years ago

So, now it's allowing it. I checked the behavior a half-dozen times, switching back and forth between 22 and 22.222 and it always failed on the latter. I don't know what's triggering the alert. It probably won't be long before it happens again, and I'll upload that file.