search

LinuxDoku / migratordotnet

Automatically exported from code.google.com/p/migratordotnet
0 stars 0 forks source link

Clarify ForeignKey Parameter Names #28

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Some confusion has been reported in declaring Foreign Keys. The names don't
make sense to everyone.

i.e.
What's the foreign table?  The table containing the foreign key, or the
table containing the primary key?

Consider renaming the parameters and adding better documentation to help
clarify this.

Original issue reported on code.google.com by geoffl...@gmail.com on 10 Jun 2008 at 6:24

GoogleCodeExporter commented 8 years ago 
I have found this as well. After looking at the source I was able to figure it 
out 
however.

I just committed r82 which gives a little more detail to 
ITransformationProvider.AddForeignKey parameter names. ForeignTable and 
ForeignColumn refer to the table/column that holds the foreign key, 
PrimaryTable and 
PrimaryColumn refer to the table/column that holds the primary key

Does that make more sense?

Original comment by dko...@gmail.com on 11 Jun 2008 at 1:28

GoogleCodeExporter commented 8 years ago

Original comment by geoffl...@gmail.com on 12 Jun 2008 at 7:34

GoogleCodeExporter commented 8 years ago 
are the changes I committed clear enough to close this issue out?

Original comment by dko...@gmail.com on 18 Jun 2008 at 2:50

GoogleCodeExporter commented 8 years ago 
I think they're clear. I'll mark as fixed.

Original comment by geoffl...@gmail.com on 19 Jun 2008 at 2:33