LinuxForHealth / FHIR

The LinuxForHealth FHIR® Server and related projects
https://linuxforhealth.github.io/FHIR
Apache License 2.0
328 stars 157 forks source link

WhereAdapter passes in the SELECT predict and not the parameter expression #274

Closed prb112 closed 4 years ago

prb112 commented 4 years ago

In fhir-database-utils, WhereAdapter passes in the SELECT predict and not the parameter expression.

The following code is potentially incorrect, and the tests are disabled.

/**
     * Start building the GROUP BY clause
     * @param expressions
     * @return
     */
    public GroupByAdapter groupBy(String... expressions) {
        return new GroupByAdapter(select);
    }

    /**
     * Start building the ORDER BY clause
     * @param expressions
     * @return
     */
    public OrderByAdapter orderBy(String... expressions) {
        return new OrderByAdapter(select);
    }

Also WhereClause HavingClause's predicate is unused.

prb112 commented 4 years ago

Cleans up the feature gaps and test gaps in database tools https://github.com/IBM/FHIR/pull/551