LinuxForHealth / hl7v2-fhir-converter

Converts HL7 v2 Messages to FHIR Resources
Apache License 2.0
89 stars 36 forks source link

#407

Closed jgrant22 closed 2 years ago

jgrant22 commented 2 years ago

Data bleed caused by missing segment in the message yaml. Same thing for Encounter.diagnosis.use

This PR includes fixes for the two threads in slack from the test team. Both fixes were simple I completely over thought the first issue which is why I moved it here to start clean.

Problem 1: One of our testers discovered a scenario where an Identifier with no system still had a system. If PV1.4 is available then we use it for the system in this case, PV1.4 was not available but we still got a system

what we got:
value: 1001918
system: urn:id:1001918
expected:
value: 1001918

Problem 2: One of our testers discovered a scenario we were missing a few mappings and that Encounter.diagnosis.use was not cycling through each DG1 segment