LinuxForHealth / hl7v2-fhir-converter

Converts HL7 v2 Messages to FHIR Resources
Apache License 2.0
89 stars 36 forks source link

OML_O21 support updates #413

Closed lisadier closed 2 years ago

lisadier commented 2 years ago

Signed-off-by: Lisa Dierkhising lisadier@us.ibm.com

Updates made: • Removed unused segments NTE, SPM, and DG1 from both DiagnosticReport resources in OML_O21.yml • Added AL1 support • Added necessary unit tests to boost coverage of critical scenarios • Simplified the message content in the tests to focus on the message-level resource testing • Added asserts to ensure that no ‘extra’ resources are created • Updated asserts to check for all expected resources • Discovered that ServiceRequests are not created for ORC segments unless an OBR is provided. • Discovered that only one ORDER group is supported per message. The HL7 message definition allows the ORDER group to be repeatable but the converter (and parser) do not support multiple ORDER groups. • Discovered that PID must be provided in OML_O21 messages to avoid FHIR validation errors, even though the HL7 message definition doesn’t require PID. The patient (from PID) is required for ServiceRequest and Condition FHIR resources to be valid. • Discovered that OBX support was not contributed and is not included. • Updated documentation to indicate partial support for OML_O21, with notes about above limitations