search

LinuxForHealth / patient-browser

Other
3 stars 7 forks source link

issue7 'next' button fix #18

Closed mcbride-p closed 3 years ago

mcbride-p commented 3 years ago

Fixed both 'Next' and 'Previous' buttons on main screen and also patient span tracker at bottom of screen.

Core issue was that scenario - where link element of /Patient/_search response returned _page parameter instead of _getpages and _getpagesoffset parameters - was not handled in context of determining/loading next page of patients list. See comments here -> https://github.com/Alvearie/patient-browser/issues/7 for more context.

mcbride-p commented 3 years ago

ok .. its going to be impossible for reviewers to compare code changes at the moment, because of formatting difference between original code and my current VSC settings ... looking at it now.

cragun47 commented 3 years ago

ok .. its going to be impossible for reviewers to compare code changes at the moment, because of formatting difference between original code and my current VSC settings ... looking at it now.

The reformatting was annoying but easy enough to filter out mentally and complete a review. Don't worry about it for my sake.

mcbride-p commented 3 years ago

@cragun47 @ewill00 many thanks for comments and approval. Hopefully I've addressed to your satisfaction above. @ewill00 - I've created another branch issue_7_takeIII with changes but without formatting issues and I'll create PR for that, if you wouldn't mind approving that and I'll merge that one and close this PR without merging.

mcbride-p commented 3 years ago

Closing without merge as merging will happen in PR -> https://github.com/Alvearie/patient-browser/pull/19