LinuxForHealth / patient-browser

Other
3 stars 7 forks source link

Missing js dependencies #37

Closed joundso closed 2 years ago

joundso commented 2 years ago

Since this commit, which removed the build/js folder, the index.html should be updated or will break since it still references the js folder:

        <script src="js/commons.js?_=2ba6dce38b719c77f7bc"></script>
        <script src="js/index.js?_=2ba6dce38b719c77f7bc"></script>

Solution 1: Add the ./build/js folder again Solution 2: Check and reconfigure the ./build/index.html.

Workaround for me:

## ----------------
## Image 1:
## ----------------
FROM alpine/git:1.0.33 as pboriginal
RUN git clone --depth=1 https://github.com/smart-on-fhir/patient-browser.git /tmp

## ----------------
## Image 2:
## ----------------
FROM alpine/git:1.0.33 as pbalvearie
RUN git clone --depth=1 https://github.com/Alvearie/patient-browser.git /tmp

## ----------------
## Image 3 (Main image):
## ----------------
FROM nginxinc/nginx-unprivileged:1.21-alpine
LABEL org.label-schema.schema-version="1.0" \
    org.label-schema.url="https://github.com/joundso/docker-collection"

## Add the build folder from alvearie:
COPY --from=pbalvearie /tmp/build /usr/share/nginx/html

## Add the `js` subfolder from the original patient browser:
COPY --from=pboriginal /tmp/build/js /usr/share/nginx/html/js

# COPY ./tmp_build_patient_browser/build /usr/share/nginx/html

CMD ["sh", "-c", "nginx -g 'daemon off;'"]

See image joundso/patient-browser:0.0.3-9002 Source: https://github.com/joundso/docker-collection/blob/master/custom_dockerfiles/patient-browser.dockerfile

mcbride-p commented 2 years ago

@joundso - Just run 'npm i' to generate the ./build/js/ folder again.