find jdk@8 in possible_javas

Linuxbrew / brew

:beer::penguin: The Homebrew package manager for Linux

https://linuxbrew.sh

BSD 2-Clause "Simplified" License

2.66k stars 237 forks source link

find jdk@8 in possible_javas #741

Closed suujia closed 6 years ago

suujia commented 6 years ago

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Some of the reasoning is at bottom of: https://github.com/brewsci/homebrew-bio/pull/272 Attempting to fix formulas that depend specifically jdk@8 issue was also found here: https://github.com/brewsci/homebrew-bio/pull/158

suujia commented 6 years ago

before changes:

$ brew irb
$ JavaRequirement.new(%w[1.8]).send("satisfied?")
=> false

after pull request changes:

$ JavaRequirement.new(%w[1.7+]).send("possible_javas")
=> [#<Pathname:/home/linuxbrew/.linuxbrew/opt/jdk/bin/java>, #<Pathname:/home/linuxbrew/.linuxbrew/bin/java>, #<Pathname:/home/linuxbrew/.linuxbrew/opt/jdk@8/bin/java>, #<Pathname:/home/linuxbrew/.linuxbrew/bin/java>]

$ JavaRequirement.new(%w[1.8]).send("satisfied?")
=> true

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

randy3k commented 6 years ago

hopefully, it also fixes https://github.com/brewsci/homebrew-base/pull/5

randy3k commented 6 years ago

bump

cc @sjackman

sjackman commented 6 years ago

Merged with a few changes in PR https://github.com/Linuxbrew/brew/pull/825. Sorry for the delay in getting to this PR. Thanks for this work, Susie!