Linuxbrew / brew

:beer::penguin: The Homebrew package manager for Linux
https://linuxbrew.sh
BSD 2-Clause "Simplified" License
2.66k stars 237 forks source link

tap: Fix slug for ssh [Linux] #745

Closed sjackman closed 6 years ago

sjackman commented 6 years ago

Fix

Error: undefined method `start_with?' for nil:NilClass

root_url: Default bottle domain is Linuxbrew [Linux]

On Linux the default bottle domain is Linuxbrew. tap.linux? requires shelling out to git and is only needed on macOS.

codecov-io commented 6 years ago

Codecov Report

Merging #745 into master will increase coverage by 6.98%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
+ Coverage    61.4%   68.38%   +6.98%     
==========================================
  Files         392      392              
  Lines       21004    20929      -75     
==========================================
+ Hits        12897    14313    +1416     
+ Misses       8107     6616    -1491
Impacted Files Coverage Δ
cmd/link.rb 83.01% <0%> (-8.65%) :arrow_down:
extend/os/mac/extend/ENV/super.rb 82.27% <0%> (-1.27%) :arrow_down:
install.rb 51.72% <0%> (-0.91%) :arrow_down:
dev-cmd/bottle.rb 43.53% <0%> (-0.15%) :arrow_down:
dev-cmd/update-test.rb 6.77% <0%> (-0.12%) :arrow_down:
cask/lib/hbc/cask.rb 94.11% <0%> (-0.09%) :arrow_down:
cask/lib/hbc/audit.rb 92.61% <0%> (-0.09%) :arrow_down:
cask/lib/hbc/container/lzma.rb 53.84% <0%> (ø) :arrow_up:
cask/lib/hbc/container/gzip.rb 100% <0%> (ø) :arrow_up:
cask/lib/hbc/container/generic_unar.rb 46.15% <0%> (ø) :arrow_up:
... and 107 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a20c336...c1d2048. Read the comment docs.