Linuxbrew / brew

:beer::penguin: The Homebrew package manager for Linux

https://linuxbrew.sh

BSD 2-Clause "Simplified" License

2.66k stars 237 forks source link

Revert "Dockerfile: install unzip and subversion too" #775

Closed sjackman closed 6 years ago

sjackman commented 6 years ago

This reverts commit f111c20805584eea65bc82a594103d9917ed2292.

codecov-io commented 6 years ago

Codecov Report

Merging #775 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #775   +/-   ##
=======================================
  Coverage   70.46%   70.46%           
=======================================
  Files         386      386           
  Lines       20702    20702           
=======================================
  Hits        14588    14588           
  Misses       6114     6114

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05aef1b...ebeeacd. Read the comment docs.

sjackman commented 6 years ago

CI was successful, so merging.

iMichka commented 6 years ago

Weird. Maybe upstream updated the tests.

sjackman commented 6 years ago

No, the latest Docker Hub build failed. https://hub.docker.com/r/linuxbrew/linuxbrew/builds/ These tests were run in the previous linuxbrew/linuxbrew Docker image that had svn and unzip installed, which is why CI succeeded. I'll fix the tests.

iMichka commented 6 years ago

The conclusion we came to is that you can not fix the tests. Because before the tests are run, all brew packages are uninstalled (including unzip and svn). So you need system unzip and svn.

sjackman commented 6 years ago

In other cases, I've skipped the tests that require system tools, like svn and unzip, if they're not available.