search

Linuxbrew / brew

:beer::penguin: The Homebrew package manager for Linux
https://linuxbrew.sh
BSD 2-Clause "Simplified" License
2.66k stars 237 forks source link

shims/linux/super/make: use command -v #826

Closed maxim-belkin closed 6 years ago

maxim-belkin commented 6 years ago

... instead of which

codecov-io commented 6 years ago

Codecov Report

Merging #826 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #826   +/-   ##
=======================================
  Coverage   70.68%   70.68%           
=======================================
  Files         384      384           
  Lines       20517    20517           
=======================================
  Hits        14503    14503           
  Misses       6014     6014

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5650c3e...b38ce6f. Read the comment docs.

maxim-belkin commented 6 years ago

Hm... I added new line at the end of the file on purpose, see https://stackoverflow.com/a/37684763

sjackman commented 6 years ago

That article is referring to a new line character at the end of the file, not a blank line, which is to consecutive new lines. Run xxd shims/linux/super/make and you'll see that your file has two new line characters at the end, where only one is needed.

maxim-belkin commented 6 years ago

nice! I haven't ever used xxd!

sjackman commented 6 years ago

Good to merge once CI is 🍏. Thanks, Maxim!