search

Linuxbrew / brew

:beer::penguin: The Homebrew package manager for Linux
https://linuxbrew.sh
BSD 2-Clause "Simplified" License
2.66k stars 237 forks source link

pkg-config and super env on Linux #848

Closed maxim-belkin closed 5 years ago

maxim-belkin commented 6 years ago

Currently, xorg formulae are picked up even if they're not dependencies of the formula being built. This is not a problem for users but is for "developers": one has to uninstall all currently installed formulae to make sure that nothing is picked up and all required dependencies are brought in by declarations within the formula.

I suspect the problem is coming from homebrew_extra_pkg_config_paths in Library/Homebrew/extend/os/linux/extend/ENV/super.rb. Thoughts?

sjackman commented 6 years ago

Probably this here: https://github.com/Linuxbrew/brew/blob/1699a7ec1347679daf102f9a8b4cc43e902aa002/Library/Homebrew/extend/os/linux/extend/ENV/super.rb#L86-L96

I agree it'd be great to back out these patches if we're no longer using depends_on :x11.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

sjackman commented 6 years ago

@maxim-belkin Would you like to test and open a PR to remove all the magic xorg hackery from extend/ENV/super.rb?

maxim-belkin commented 6 years ago

I've done it locally already - just didn't have a chance to submit a PR

maxim-belkin commented 6 years ago

quick question: I was replacing contents of functions with [] so they return no "extra" paths. I guess we can also simply delete them right?

sjackman commented 6 years ago

Yes, those empty functions can be deleted.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

sjackman commented 5 years ago

I believe this issue was resolved by https://github.com/Linuxbrew/brew/commit/9769fb22fe2cef2dc00420111fd4ecf5b19e5c0d

maxim-belkin commented 5 years ago

I think you're right (no time to test it at the moment though)