search

Linuxbrew / brew

:beer::penguin: The Homebrew package manager for Linux
https://linuxbrew.sh
BSD 2-Clause "Simplified" License
2.65k stars 235 forks source link

bin/brew: remove bash redirection #889

Closed iMichka closed 5 years ago

iMichka commented 5 years ago

This was added back then to allow to run brew if you had no /bin/bash. There are now multiple places in the code where /bin/bash is hardcoded, which makes this change useless without fixing the other places.

If needed we can try to provide a better solution later on, but I think removing this allows to have one patch less to backport to Homebrew.

iMichka commented 5 years ago

Of course this is open for discussion :)

codecov[bot] commented 5 years ago

Codecov Report

Merging #889 into master will decrease coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #889      +/-   ##
==========================================
- Coverage   70.67%   70.66%   -0.02%     
==========================================
  Files         406      406              
  Lines       21931    21931              
==========================================
- Hits        15500    15497       -3     
- Misses       6431     6434       +3
Impacted Files Coverage Δ
utils/analytics.rb 81.81% <0%> (-6.82%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f1938c...07fe402. Read the comment docs.