search

Linuxfabrik / monitoring-plugins

220+ check plugins for Icinga and other Nagios-compatible monitoring applications. Each plugin is a standalone command line tool (written in Python) that provides a specific type of check.
https://linuxfabrik.ch
The Unlicense
220 stars 51 forks source link

check2basket: do not adjust datafield_ids if not necessary #479

Closed NavidSassan closed 2 months ago

NavidSassan commented 3 years ago

this reduces the changes in commits

NavidSassan commented 3 years ago

In GitLab by @markuslf on Nov 24, 2021, 09:37

Please explain me what to do on this issue. ;-)

NavidSassan commented 3 years ago

when running check2basket --auto and there is a new check, all datafield_ids of the later processed checks are adjusted, since currently the datafield_id is just a global incrementing number. this leads to a lot of changes which are not needed (ie the only change in the json file is the datafield_ids).

the easiest is probably to start with datafield_id = 0 for each file (since basket-join renumbers them anyway during joining).

NavidSassan commented 2 years ago

In GitLab by @markuslf on Feb 16, 2022, 21:30

What to do on this issue?

markuslf commented 2 years ago

What to do on this issue depends on what's all about with the new UUIDs in Icinga Director.

markuslf commented 2 months ago

I think we fixed that with https://github.com/Linuxfabrik/monitoring-plugins/commit/21f4fbde738ada4f7d3c8fdea19384ee4a893ec0, but we just forgot to close this issue.