All plugins: change behavior when handling default values

Linuxfabrik / monitoring-plugins

220+ check plugins for Icinga and other Nagios-compatible monitoring applications. Each plugin is a standalone command line tool (written in Python) that provides a specific type of check.

https://linuxfabrik.ch

The Unlicense

221 stars 51 forks source link

All plugins: change behavior when handling default values #540

Open markuslf opened 2 years ago

markuslf commented 2 years ago

According to https://github.com/Linuxfabrik/monitoring-plugins/issues/352#issuecomment-1061491198, in all plugins in parse_args(), change the default in an append action to None and after parsing the value in main() is None, put the desired defaults there.

The first plugin that implements this is php-status.

markuslf commented 2 years ago

Problems with this approach:

Help texts don't show defaults anymore (this has an impact on check2basket)
SysAdmin can't disable a parameter anymore, like in systemd-unit plugin