Closed seraphyn closed 1 year ago
Hmmm... in a datacenter environment, the majority of admins voted for offline capabilities of the plugins.
If we fetch version info from Github & Co. (what we did in the past), we only know that there is a new version, not whether it is end-of-life. Experience has shown that the "beware, you are running 1.2.3, but there is 1.2.4 available" warning is not effective in a datacenter environment - it is much more important to know if it is EOL.
Thinking out loud:
myproduct-eol
(can stay offline) plugin plus myproduct-version
(goes online to Github or product pages, the "old" behavior).*-version
plugins try to get the EOL info from https://endoflife.date, and only if that fails after a reasonable timeout (3 seconds) they use their built-in offline info.Currently I prefer the latter, but have to think about this.
I would like to know 2 things from a version check:
In general terms I would like a switch to enable online requests but for GitLab specifically one can just ask it, if it's up to date:
https://gitlab.example.com/admin/version_check.json
{"latest_stable_versions":["16.0.1"],"latest_version":"16.0.1","severity":"success","critical_vulnerability":false,"details":""}
https://about.gitlab.com/handbook/sales/process/version-check/#use-the-internal-api-to-check-the-cache
In summary, we will improve this and most of the current "version" plugins like this:
Plugin will raise an alert when
That sounds wonderful, thank you
Re-opened, we still need to implement this. ;-)
Now fetching info from https://endoflife.date first, then reading from local file (requires updated libraries):
Moving the "check for gitlab security patches" feature request to the new ticket https://github.com/Linuxfabrik/monitoring-plugins/issues/688
Describe the solution you'd like
In the Iciniga plugin gitlab-version the current version of gitlab is hardcoded (Line 31 - Line 275).
It would be good if there was an option here that pulls the latest released version of gitlab from the internet.
As an example:
Many greetings and thanks for the plugins
Christian
Additional context
No response