Linuxfabrik / monitoring-plugins

200+ check plugins for Icinga and other Nagios-compatible monitoring applications. Each plugin is a standalone command line tool (written in Python) that provides a specific type of check.
https://linuxfabrik.ch
The Unlicense
207 stars 48 forks source link

about-me: Pipes ("|") within the plugin output lead to broken perfdata #741

Closed K0nne closed 3 months ago

K0nne commented 5 months ago

This issue respects the following points:

Which variant of the Monitoring Plugins do you use?

Bug description

Pipe-symbols in the plugin output on some of our systems lead to corrupted performance data.

Steps to reproduce - Plugin call

/usr/lib64/nagios/plugins/about-me

Steps to reproduce - Data

Blurred console output
image

icingaweb2 visualisation
image

icinga2 api output
image

Environment

Linux 5.10.0-27-amd64 #1 SMP Debian 5.10.205-2 (2023-12-31) x86_64 GNU/Linux

Plugin Version

about-me: v2023112901 by Linuxfabrik GmbH, Zurich/Switzerland

Python version

3.9.2

List of Python modules

No response

Additional Information

No response

slalomsk8er commented 5 months ago

This reminds me of https://github.com/Linuxfabrik/monitoring-plugins/issues/727

markuslf commented 3 months ago

Fixed in https://github.com/Linuxfabrik/lib/commit/c9072e3a537054e0c5b57899a17385f4bb860698