Closed kbucheli closed 3 months ago
I rejected the PR because we don't want to implement a hardcoded lowercase here, and leave it now up to the admin how exactly he wants to match. If you want to match case-insensitively, in --ignore-regex
, you can use the (?i)
switch. The plugin and the readme have been updated in the help section to reflect that.
It looks like there is a misunderstanding. I see I did not explicitly state the problem as such, I just provided an example.
The problem is that the regex is applied on the lower cased log message. This does not make much sense. And it puzzled me as admin very much when I have a regex with the exact message at it does not match. And all regex tests you do with any tester/test code outside matches...
There are two sensible options on how to deal with this:
For which of the above options shall I provide a PR?
You are absolutely right. Thanks for offering a PR, but I just made the plugin case-sensitive in every way (which is much more consistent and expected behavior).
Perfect, thank you very much!
I had to search a bit until I understood why
is not matched by the regex