[Bug]: Flatpak install says "nightly" when I install latest stable

LinwoodDev / Butterfly

🎨 Powerful, minimalistic, cross-platform, opensource note-taking app

https://butterfly.linwood.dev

GNU Affero General Public License v3.0

893 stars 62 forks source link

[Bug]: Flatpak install says "nightly" when I install latest stable #570

Open markwmuller opened 5 months ago

markwmuller commented 5 months ago

What happened?

Installing Butterfly via flatpak (https://flathub.org/apps/dev.linwood.butterfly) gives me version 2.0.0, but the banner at the top says "Butterfly Nightly". I'm guessing there's a mixup somewhere.

I'm using Ubuntu 22.04.

Version

2.0.0

Platform

Linux

Relevant log output

No response

Code of Conduct

[X] I agree to follow this project's Code of Conduct

CodeDoctorDE commented 5 months ago

Thanks for reporting. The bug shouldn't be too critical, with the nightly version you can try out the collaboration feature

CodeDoctorDE commented 5 months ago

Fixed in 2.0.1

CodeDoctorDE commented 5 months ago

Reopened because it didn't fix the problem

derkrasseleo commented 5 months ago

Can confirm, just installed butterfly flatpak and also got the nightly

CodeDoctorDE commented 5 months ago

Yeah, the problem is: The check for nightly is wrong: https://github.com/LinwoodDev/Butterfly/blob/da8ed04432b84810dcc0eb9b63023ffb79c8aad1/.github/workflows/build.yml#L160

The github.event_name is "push" and we don't get the information if the running job is inside a prerelease or not