[Feature request]: allow pasting images

LinwoodDev / Butterfly

🎨 Powerful, minimalistic, cross-platform, opensource note-taking app

https://butterfly.linwood.dev

GNU Affero General Public License v3.0

981 stars 67 forks source link

[Feature request]: allow pasting images #605

Closed MrGumpIT closed 5 months ago

MrGumpIT commented 7 months ago

Is your feature request related to a problem? Please describe

No response

Describe your feature request!

currently if you take a screenshot it is not possible to paste it into the drawing area on windows

Additional context

No response

Code of Conduct

[X] I agree to follow this project's Code of Conduct

CodeDoctorDE commented 7 months ago

good idea but then we need access to the native clipboard

MisterE123 commented 6 months ago

I agree that this is a necessary feature.

CodeDoctorDE commented 6 months ago

i created an issue on my library that i developed for clipboard: https://github.com/LinwoodDev/dart_pkgs/issues/5

CodeDoctorDE commented 6 months ago

or wait, super_clipboard is exactly what i need https://pub.dev/packages/super_clipboard

CodeDoctorDE commented 6 months ago

Okay I started implementing it in #651

The custom clipboard is not available on android < 6. I will still support android 5 and 5.1 and use the current implementation as fallback.
All app specific copy/paste will also be handled by the native clipboard manager and override the current copied data inside the clipboard.
I didn't test it, it can work fine now or doesn't work. You can test it under https://butterfly-git-feature-native-clipboard-linwood.vercel.app/

MrGumpIT commented 6 months ago

mhh not working

MisterE123 commented 6 months ago

Yeah not working on Windows.

CodeDoctorDE commented 6 months ago

Hello, Thanks for testing it. I fixed it in the next commit. I tested it myself on windows 11 with copy/pasting an element and pasting a native image from the clipboard. It would be nice if you could test it too so I can put it in the next beta.

Here are the links:

Web: https://butterfly-git-feature-native-clipboard-linwood.vercel.app/
Native: https://github.com/LinwoodDev/Butterfly/actions/runs/8579883201?pr=651 (once it built, the buttons are at the bottom of the page, you need to be authenticated in github otherwise the buttons doesn't work)

CodeDoctorDE commented 6 months ago

Hmm okay, I tested it a bit and native web clipboard isn't possible right now... But on native platforms on mobile and desktop it should work

CodeDoctorDE commented 5 months ago

Added in 2.1.0-beta.5