LinwoodDev / Butterfly

🎨 Powerful, minimalistic, cross-platform, opensource note-taking app
https://butterfly.linwood.dev
GNU Affero General Public License v3.0
891 stars 62 forks source link

[Bug]: performance issue on large single page #667

Open Luciogi opened 2 months ago

Luciogi commented 2 months ago

What happened?

A bug happened! when moving around on canvas

Platform Tested: WPA(firefox) Android

File: https://github.com/LinwoodDev/Butterfly/files/15015668/butterfly.bfly.zip

Version

2.1.0-rc.0

Platform

Android

Relevant log output

No response

Code of Conduct

CodeDoctorDE commented 2 months ago

thanks for reporting, i tested it myself and on firefox it is very buggy, on windows it seems to handle it (maybe because the pc is better than a phone)

Luciogi commented 2 months ago

Umm After comparing Chromium and firefox (on Laptop with power mode on performance) both give nearly same performance when moving around on canvas. From my previous observations I think so my laptop was running on power saving mode

I think that, tools like path eraser and eraser are causing performance issue

CodeDoctorDE commented 2 months ago

Okay thanks. I just wanted to be sure I could reproduce this behavior. I will look at it and try to fix it

Luciogi commented 2 months ago

path eraser tool when delete an element whole visible area is canvas is rerendered. I am also not sure if it refresh objects what are not visible on screen

https://github.com/LinwoodDev/Butterfly/assets/84625092/377dd703-9a3f-4633-837c-87ee82a10409

CodeDoctorDE commented 2 months ago

Which version do you use currently?

Luciogi commented 2 months ago

2.1.0-rc.3 just installed latest apk from gitbub actions

CodeDoctorDE commented 2 months ago

Okay thanks, i will check it

CodeDoctorDE commented 1 month ago

fixed in 2.1.1-rc.1

Luciogi commented 1 month ago

https://github.com/LinwoodDev/Butterfly/assets/84625092/2d7c34d1-fb4a-4cdc-968d-14ca765e6b6e

CodeDoctorDE commented 1 month ago

thanks for testing, I will try to improve this a bit