LinwoodDev / Butterfly

🎨 Powerful, minimalistic, cross-platform, opensource note-taking app
https://butterfly.linwood.dev
GNU Affero General Public License v3.0
888 stars 62 forks source link

[Feature request]: Only allow strokes to be deleted with path eraser #680

Closed MrGumpIT closed 3 weeks ago

MrGumpIT commented 2 months ago

What happened?

On android and windows, if you import a PDF, then write on it, if you use the Erase Stroke it will also delete the PDF

Version

v2.1.0-rc.1

Platform

Android

Relevant log output

No response

Code of Conduct

CodeDoctorDE commented 2 months ago

This is intentional. Should we disable this? Only the normal eraser ignores other elements that are not paths

MrGumpIT commented 2 months ago

I think so, it's confusing, when I want to delete a pdf page or an image or whatever, I just select it and delete it

CodeDoctorDE commented 2 months ago

I'm currently thinking:

We could make an option to path eraser to only erase path elements and add it to the property view. The name is also a bit confusing

MrGumpIT commented 2 months ago

I think both should only erase strokes of the pen. anything else labels, PDFs, images can be selected and deleted, it's a common use in apps like this

CodeDoctorDE commented 2 months ago

Hmm okay and how should the other elements be removed?

MrGumpIT commented 2 months ago

selecting and deleting them

CodeDoctorDE commented 2 months ago

I would combine it with #683 and put it in the 2.2 release. It's a bigger feature and I just want to go forward with it. Maybe we add an optional feature to include all elements

MrGumpIT commented 1 month ago

What do you think about a similar approach where the user selects what to delete Screenshot_20240517-103431

CodeDoctorDE commented 1 month ago

Looks good. Maybe we add this as a toolbar in the path eraser and eraser

MrGumpIT commented 1 month ago

it could be a solution. in my opinion you should either let the user decide what to delete, adding the icons in the tools, or have the eraser delete only pen strokes (drawings etc.) and let it delete everything else (images, pdfs etc.) using the selection. you choose which approach is best.

CodeDoctorDE commented 1 month ago

I think a toolbar is better. If you want to delete multiple things it's easier to use the eraser

CodeDoctorDE commented 3 weeks ago

Added in 2.2.0-beta.0