LinwoodDev / Butterfly

🎨 Powerful, minimalistic, cross-platform, opensource note-taking app
https://butterfly.linwood.dev
GNU Affero General Public License v3.0
888 stars 62 forks source link

implements arrow #690

Closed MrGumpIT closed 1 month ago

MrGumpIT commented 1 month ago

add arrow shape add arrow icon add arrow icon in dialog

Can you implement rendering like you did for the triangle?

vercel[bot] commented 1 month ago

@MrGumpIT is attempting to deploy a commit to the Linwood Team on Vercel.

A member of the Team first needs to authorize it.

CodeDoctorDE commented 1 month ago

Hmm do you think this is a basic shape? I'm more thinking about adding arrows, stars and more as a component in the core pack. It's maybe related to #358

CodeDoctorDE commented 1 month ago

The thing is: I don't want to add more things that we need in the basic shapes. Otherwise it gets very crowded. Maybe we can use this principle: everything that can be detected by the shape detection is a basic shape that we could add.

For an arrow you have the problem that you can have a dotted line, a full sarrow head, a outlined, ... In the basic core pack we can construct an arrow out a line and a triangle

MrGumpIT commented 1 month ago

we can do so. Where should I start from to add the basic package?

CodeDoctorDE commented 1 month ago

Hmm, I dont like zip/bfly files in this repo. What do you think about making it code driven? A generateCorePack function that adds these things? Currently the pack uses the old json format. Maybe we should readd this format if we dont use the other idea?

MrGumpIT commented 1 month ago

where is the actual code so I get an idea of ​​what we're talking about

CodeDoctorDE commented 1 month ago

The getCorePack is inside the defaults.dart

MrGumpIT commented 1 month ago

what if we simply had SVGs as templates, loaded via json

CodeDoctorDE commented 1 month ago

Hmm yeah... SVGs are really cool. We need to look about the license of these to add this. But maybe not really for arrows. If you want to make the line of the arrow longer, you also make the head longer... Hmm that's very tricky

MrGumpIT commented 1 month ago

Many sites online offer free svg, but you need to check first

CodeDoctorDE commented 1 month ago

i would close this for now... feel free to open another pr if you are done. Maybe we should implement something like a "Anchor" (like in figma) to deal with sizing