[Bug]: imports have bad quality

LinwoodDev / Butterfly

🎨 Powerful, minimalistic, cross-platform, opensource note-taking app

https://butterfly.linwood.dev

GNU Affero General Public License v3.0

888 stars 62 forks source link

[Bug]: imports have bad quality #704

Closed MrGumpIT closed 1 month ago

MrGumpIT commented 1 month ago

What happened?

I believe that some changes to the canvas have led to poor quality of the imported files, this happens with both PDFs and images. It is very noticeable when using zoom. It doesn't seem to happen in the stable version, but in the others it does.

Version

all except stable

Platform

Windows

Relevant log output

No response

Code of Conduct

[X] I agree to follow this project's Code of Conduct

CodeDoctorDE commented 1 month ago

Can you explain it more? Which exac version did you test? 2.1.0? 2.1.1-rc.0? Did it change with your pr? Can you send a screenshot?

MrGumpIT commented 1 month ago

I think the problem is due to the zoom. when I zoom in and out the quality drops dramatically. I don't know if there is a solution.

CodeDoctorDE commented 1 month ago

bug reproducable, feel free to create a pr for a fix

MrGumpIT commented 1 month ago

how does zoom work, what parts of code should I look at?

CodeDoctorDE commented 1 month ago

zoom just changes the state in transformcubit, that will be used inside the paint methods of the image renderers that will be executed in the viewpainter

CodeDoctorDE commented 1 month ago

Fixed in #707 by yourself :) Should land in 2.1.1-rc.1