search

Linxcathyyy / pe

0 stars 0 forks source link

DG implementation looks messy and hard to read #12

Open Linxcathyyy opened 3 years ago

Linxcathyyy commented 3 years ago

Instead of putting all 3 different commands (e.g. EditCustomerCommand, EditEmployeeCommand and EditSupplierCommand) into one section (e.g. Edit command), it will be better if there are 3 sub-sections under the Edit command section for better readability. As a developer, I found it confusing and hard to read.

nus-pe-bot commented 3 years ago

Team's Response

I am not sure what you are referring to. We explicitly stated that due to the similarities in implementation, we would use the editC command to explain all three versions. Additionally, we did not even mention all three edits in the DG. Moreover, we linked the UG in that section where the edit commands are split into editCustomer, editEmployee and editSupplierCommand.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]