Add TypeScript types declaration file

LionC / express-basic-auth

Plug & play basic auth middleware for express

325 stars 57 forks source link

Add TypeScript types declaration file #2

Closed toverux closed 7 years ago

toverux commented 7 years ago

As discussed via email :)

Updated my original file to take in account what was missing
Added JSDoc in the decl (very practical with IDEs!)
Added some hints about usage in TypeScript

Thank you for having proposed to add TS support. We've made the world a better place ;)

LionC commented 7 years ago

I will try to review all the changes this evening - thank you a lot for the time you put in, especially for documenting it so well!

LionC commented 7 years ago

I looked it over, I will change some minor dtylistic things (like semicolons) for consistency purposes tomorrow and merge it. Thanks!

toverux commented 7 years ago

Ahah, yeah, I've noticed that you don't usually put them - but I'm a semicolon guy and the StandardJS style is not very common in the TypeScript community, so I've kept the old-school style. But consistency is more important so I won't bother you with that =)