LionC / express-basic-auth

Plug & play basic auth middleware for express
328 stars 57 forks source link

can not use var as user credential #8

Closed zackijack closed 6 years ago

zackijack commented 6 years ago

i can not use var as user credential

const username = process.env.APP_USERNAME;
const password = process.env.APP_PASSWORD;
app.use(basicAuth({
  users: { username: password },
  unauthorizedResponse: {
    message: 'Bad credentials',
  },
}));

because the username is considered as a property, instead of variable maybe you can make it be like this:

const username = process.env.APP_USERNAME;
const password = process.env.APP_PASSWORD;
app.use(basicAuth({
  users: {
    username: username,
    password: password,
  },
  unauthorizedResponse: {
    message: 'Bad credentials',
  },
}));
kambala3000 commented 6 years ago

@zackyjack try it

const username = process.env.APP_USERNAME;
const password = process.env.APP_PASSWORD;
const users = {};
users[username] = password;

app.use(basicAuth({
  users,
  unauthorizedResponse: {
    message: 'Bad credentials',
  },
}));
LionC commented 6 years ago

Thanks @kambala3000 to point that out - that is actually a syntax problem, so I am closing this issue for now.

zackijack commented 6 years ago

Thanks @kambala3000 @LionC