search

LionWeb-io / lionweb-java

Apache License 2.0
3 stars 1 forks source link

Move addAnnotation and removeAnnotation to ClassifierInstance #156

Closed ftomassetti closed 4 months ago

ftomassetti commented 4 months ago

Move to ClassifierInstance annotations specific methods previously only available on AbstractClassifierInstance Fix #153

enikao commented 4 months ago

Why not moving it to AbstractClassifierInstance? Annotations can have annotations.

ftomassetti commented 4 months ago

Why not moving it to AbstractClassifierInstance? Annotations can have annotations.

We are moving them to ClassifierInstance, which is more general than AbstractClassifierInstance. AnnotationInstance extendsClassifierInstance`, so the methods are also available there.

ftomassetti commented 4 months ago

I think we covered the comments, so unless there are more doubts I would go ahead and merge this one