search

LionWeb-io / lionweb-repository

Reference implementation of LionWeb repository
Apache License 2.0
2 stars 1 forks source link

Workspace setup #11

Closed ftomassetti closed 6 months ago

ftomassetti commented 6 months ago

Following up on #9 this is an attempt to divide the APIs into modules that could potentially be activated separately.

For now I just put the init route into a separate package called dbadmin I then moved all the rest of the code to a package called core. Based on suggestions by @dslmeinte I made the tsconfig.json files of the packages inherit from the root tsconfig.json.

I then created some tasks in the root projects which basically invoke the same tasks in the core package or the core and the dbadmin packages.

ftomassetti commented 6 months ago

Now the PR got quite big, but most of the files were simply moved

joswarmer commented 6 months ago

Sorry, I was not notified of this PR and have done more or less the same :-(.

joswarmer commented 6 months ago

@ftomassetti Does your branch build correctly?

ftomassetti commented 6 months ago

@ftomassetti Does your branch build correctly?

Yes, at least locally it builds.

However, if you already re-done the same changes, I am happy to close this PR

joswarmer commented 6 months ago

The build problem was on the CI, as splitting into different packages invalidates a number of paths in the code. I'll merge your PR and my branch into one and make a PR from that.

joswarmer commented 6 months ago

Merged changes from this branch into branch for next PR.