search

LionWeb-io / lionweb-repository

Reference implementation of LionWeb repository
Apache License 2.0
2 stars 1 forks source link

Adding tags or release on NPM #36

Closed ftomassetti closed 3 months ago

ftomassetti commented 4 months ago

When using the lionweb-repository, it would be convenient to be able to refer to a specific version. It would be ideal to have versions of npm which we can use. Alternatively it would be useful to have tags indicating various versions, as we would clone the repository, checkout the tag and build that specific version. Without npm version or tags, we use scripts that just clone the repository and use the most recent commit. But that mean that when APIs change, tests that used to pass now fail

joswarmer commented 4 months ago

Npm releases do give stable versions, but in itself an npm release does not tell which commit is being used, we need tags or branches or something similar in the code repo as well.

ftomassetti commented 4 months ago

It would be very nice to find an equivalent for npm of the gradle release plugin. Basically if offers a task which:

  1. Verify there are no uncommited or unpushed changes
  2. Create a git tag and publish it
  3. Perform the actual release
  4. Update the version
  5. Push everything to git
joswarmer commented 4 months ago

As usual in the JS world there are (too) many options to choose from:

A comparison is e.g. here: release-management-for-nx-monorepos-semantic-release-vs-changesets-vs-release-it-

joswarmer commented 3 months ago

We have this now, don't we?

ftomassetti commented 3 months ago

We have this now, don't we?

I am not sure: I do now see tags, and I cannot find publications of this package in nom (I searched for the term "lionweb")

Screenshot 2024-04-03 at 14 04 24

Are NPM packages published somewhere?

joswarmer commented 3 months ago

Ahh! yes, the packages themselves are not published to npm. Only the docker image is built and published at github.

I did think this would be enough because the server runs as one application. I was wondering whether the published npm packages would be used at all.

joswarmer commented 3 months ago

By the way, did you push a version tag? I cannot see one.

joswarmer commented 3 months ago

Note that git needs a special command for pushing tags: 

git push origin <tag_name>
ftomassetti commented 3 months ago

I have now pushed the tag (I delete a couple of tags I pushed by mistake)

ftomassetti commented 3 months ago

I think we have now the tags so I think we can close this one