search

LionWeb-io / lionweb-repository

Reference implementation of LionWeb repository
Apache License 2.0
2 stars 1 forks source link

server-config.json contains invalid JSON #70

Closed ftomassetti closed 5 days ago

ftomassetti commented 1 week ago

See: https://github.com/LionWeb-io/lionweb-repository/blob/e9738d3191370df767c456d70102ddc808ea782a/packages/server/server-config.json#L14

n+app is not supposed to be there

ftomassetti commented 1 week ago

Note that the application started despite the file being invalid. I think it should have exited instead

joswarmer commented 6 days ago

Note that the application started despite the file being invalid. I think it should have exited instead

I did this deliberately, as the file format isn't really validated completely. But it probably is a good idea to fail starting the server if an error has been found.