search

LionWeb-io / lionweb-typescript

Implements (select parts of) the LionWeb specification, and tooling around that - all in TypeScript.
Apache License 2.0
10 stars 4 forks source link

Improve PlantUML and Mermaid diagram generation #128

Closed dslmeinte closed 4 months ago

dslmeinte commented 4 months ago

Fixes issue #127

enikao commented 4 months ago

You might want to add a test that references to and/or annotations for Node are still part of the diagram.

dslmeinte commented 4 months ago

You might want to add a test that references to and/or annotations for Node are still part of the diagram.

Good call, as I found plenty of bugs and missing stuff while doing that: see latest 2 commits (on top of a force-pushed rebased commit).

enikao commented 4 months ago

Regarding the annotation test rendering:

image

  1. Our links are directed, why they don't have an arrowhead?
  2. I'd use a different connector (maybe dashed or dotted) for Annotation.annotates to clearly differentiate it