search

LionWeb-io / lionweb-typescript

Implements (select parts of) the LionWeb specification, and tooling around that - all in TypeScript.
Apache License 2.0
10 stars 4 forks source link

Serialization custom primitive types #159

Closed ftomassetti closed 4 months ago

ftomassetti commented 4 months ago

We recently introduced support for deserializing custom primitive types. With this PR we similarly introduce support for the serialization of such types, following the same approach used for deserialization.

ftomassetti commented 4 months ago

Interestingly I get errors in GitHub actions that I do not get when running the test and lint task locally. For this reason I open a draft PR

dslmeinte commented 4 months ago

Weird: I'm not seeing any test failures and lint warnings in the GitHub Actions you've triggered, and neither do I see such locally. So, I guess it's a matter of “...works on your machine...NOT!” :)

ftomassetti commented 4 months ago

Weird: I'm not seeing any test failures and lint warnings in the GitHub Actions you've triggered, and neither do I see such locally. So, I guess it's a matter of “...works on your machine...NOT!” :)

I have since fixed it, but before it was failing: https://github.com/LionWeb-io/lionweb-typescript/actions/runs/9302052830/job/25601454591

dslmeinte commented 4 months ago

I have since fixed it, but before it was failing: https://github.com/LionWeb-io/lionweb-typescript/actions/runs/9302052830/job/25601454591

(That one really only has 1 build error.)

dslmeinte commented 4 months ago

@ftomassetti Could you write a changelog entry (for version 0.6.6) in the README of the core package?

ftomassetti commented 4 months ago

@ftomassetti Could you write a changelog entry (for version 0.6.6) in the README of the core package?

Done

dslmeinte commented 4 months ago

(@ftomassetti : please squash-merge)

ftomassetti commented 4 months ago

Thank you @dslmeinte !