D8 composer require not pulling local path - Githubissues

LionsAd / drupal_ti

Drupal - Travis Integration

82 stars 37 forks source link

D8 composer require not pulling local path #94

Closed mglaman closed 8 years ago

mglaman commented 8 years ago

Follow up to #91.

We found a weird bug in our Travis builds. Basically the d.o endpoint was always being chosen, and not the currently linked path.

We made a quick fix in: https://github.com/drupalcommerce/commerce/commit/e367d17b3842c503092bf1bc4042f9f528073180

Opening PR, but I'll test on my mglaman/commerce fork with my drupal_ti fork to make sure everything is 👍

LionsAd commented 8 years ago

Looks good to me.

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling 29e85190ff9fd8aaf5c7b9b9d9d704368ee4f7af on mglaman:d8-composer-followup into 81e462abc1224e1e9caf36803504bda188927193 on LionsAd:master.

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling 29e85190ff9fd8aaf5c7b9b9d9d704368ee4f7af on mglaman:d8-composer-followup into 81e462abc1224e1e9caf36803504bda188927193 on LionsAd:master.

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling 29e85190ff9fd8aaf5c7b9b9d9d704368ee4f7af on mglaman:d8-composer-followup into 81e462abc1224e1e9caf36803504bda188927193 on LionsAd:master.

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling 29e85190ff9fd8aaf5c7b9b9d9d704368ee4f7af on mglaman:d8-composer-followup into 81e462abc1224e1e9caf36803504bda188927193 on LionsAd:master.

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling 29e85190ff9fd8aaf5c7b9b9d9d704368ee4f7af on mglaman:d8-composer-followup into 81e462abc1224e1e9caf36803504bda188927193 on LionsAd:master.

mglaman commented 8 years ago

Okay, this did the trick.

> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Installing drupal/state_machine (dev-1.x bf975f5)
    Cloning bf975f5efdc8501c3c8d7cbf358dacad250085ca

> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Installing drupal/entity (dev-1.x f12bdca)
    Cloning f12bdcafae712ddf00364e9977014a3aa95eafd6

> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Installing drupal/profile (dev-1.x 13f8026)
    Cloning 13f8026a7d1bcc67b15002cafe1276d67b140363

> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Installing drupal/inline_entity_form (dev-1.x 7b8d610)
    Cloning 7b8d6107692d5b8379c53f84e278fecf40e8d3cb

> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Installing drupal/address (dev-1.x 30d0269)
    Cloning 30d0269f9090526e939f209a4bc2cbee597259b5

> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Installing drupal/commerce (dev-3f904ebba83acb6288be43bd85e9e96ec13cfc73)
    Symlinked from /home/travis/build/mglaman/commerce

Sample build here: https://travis-ci.org/mglaman/commerce/jobs/161213424

We just still needed to run drupal_ti_ensure_module in our custom step to enable all the extra submodules. But otherwise 👍 order of the composer repository config fixes it. That was a huge "TIL".