search

LionyxML / auto-dark-emacs

Auto-Dark-Emacs is an auto changer between 2 themes, dark/light, following MacOS, Linux or Windows Dark Mode settings
GNU General Public License v2.0
142 stars 34 forks source link

Not required for emacs-plus formula #11

Closed Andre0991 closed 1 year ago

Andre0991 commented 2 years ago

Hi. I have been using this package for a few months and it has been super useful.

However, after reading the options provided by the emacs-plus 1 formula, I see that it provides a hook for when the system appearance is changed.

This is arguabily nicer than a pull mechanism, which is implemented by auto-dark-emacs. So, I’m wondering if it would make sense to document in auto-dark-emacs README that emacs-mac users should use the hook instead, while this package could be useful for other Emacs versions for ns.

Thanks!

LionyxML commented 1 year ago

Hello there!

This is a really good Idea. I'll sure consider including this feature. I'll just have to make sure I won't break anything :)

Thanks!

LionyxML commented 1 year ago

@Andre0991 There you have it.

Just implemented it.

Should be on MELPA now. Thanks for the heads up :)

PR: #15

Andre0991 commented 1 year ago

Great, thanks!