Closed luisgerhorst closed 6 months ago
Hello there @luisgerhorst ! Is this related to your PR #40?
Sorry I didn't get what you mean. I am not familiar with doom emacs myself. Would you explain it to me?
Sure, no it's unrelated. This is not really related to doom, doom is just an example where this feature was implemented. Currently, there is no way to tell auto-dark-theme to use no theme as dark/light theme (i.e., unload all themes but not load any new theme). This suggests implementing this feature by allowing the theme to be set to nil. Does this make it clear?
Hey @luisgerhorst !
Yep, I got you.
A "no theme" option for ether dark and light modes is not currently implemented.
Maybe the better approach would be allowing the variables auto-dark-dark-theme
and auto-dark-light-theme
to be nil and treating them when (load-theme)
is called. I'd keep the hooks working though.
@luisgerhorst , thanks for the suggestion. Closing this discussion.
auto-dark-mode
can now use nil
as a theme option.
Awesome, thank you! :)
A simple if clause here
https://github.com/LionyxML/auto-dark-emacs/blob/65cc6337de9030ea7cae4661389019b9443543a2/auto-dark.el#L164
would probably do it. Doom supports the same for
doom-theme
because the default colors are also nice: