search

LionyxML / auto-dark-emacs

Auto-Dark-Emacs is an auto changer between 2 themes, dark/light, following MacOS, Linux or Windows Dark Mode settings
GNU General Public License v2.0
140 stars 34 forks source link

Feature request: Day Time-based method #44

Open quienn opened 7 months ago

quienn commented 7 months ago

Right now when a user enables auto-dark-mode when there's no suitable platform detection method it errors out saying so.

For those users (like me, 'cause I'm using Termux and apparently I can't get the cmd uimode thing to work. 🤨), there should be a daytime method in which the user specifies her preferred interval, with custom auto-dark-daytime-(sunrise/sunset)-time variables.

This feature could potentially be useful for EXWM users too! And for them, there could also be a location method based on something like Geoclue, but that's out of the scope of this issue.

LionyxML commented 7 months ago

Hello there @quienn !

I think the way we implemented the error handling (if no method for switching is found) makes more damage than good by now, I might be changing it to "just a Waning on message buffer", thus avoiding Emacs loading issues.

That said, I'd prefer keeping the original functionality to the package, which is, "just follow the system theme settings".

The feature you described is nice, I just think it would not be the case to auto-dark to implement it.

A while ago someone contacted me to talk about this package: https://github.com/pedroangelo/theme-rotation.el from @pedroangelo.

I haven't tested it yet, but it looks nice, with some additions it might become what you just described.