Liooo / jquery-datatables-row-grouping

Automatically exported from code.google.com/p/jquery-datatables-row-grouping
0 stars 0 forks source link

RowGrouping does not work on Hebrew columns #23

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I'm trying to use RowGrouping on a table. 

The table has many columns, some are numbers, some dates, and some Hebrew words.

RowGrouping works great on all of the columns beside the Hebrew words columns. 

Should this work fine with no-Latin letters, all UTF-8 chars ?

Thanks in advance,

Nir

Original issue reported on code.google.com by Nir....@gmail.com on 29 Mar 2012 at 1:45

GoogleCodeExporter commented 8 years ago
Hi,

do you have some online example. I have not used it that way but I don't know 
why it should not work.

Thanks,
Jovan

Original comment by joc...@gmail.com on 4 Apr 2012 at 7:51

GoogleCodeExporter commented 8 years ago
After issue 7 patch grouping by Cyrillic strings shows only first group

Use simple grouping on column with Cyrillic symbols (maybe, any non-ascii127 
characters - at least Hebrew too).

Only first grouping row inserted into table.

Reproduced under Windows 7 64 bit in Chrome 18.0.1025.162 and Internet Explorer 
9.0.8112.16421.

Problem is in line 122:
return sGroup.toLowerCase().replace(/\W+/g, "-");
returns '-' for cyrillic strings.

Maybe general solution should use reversible encoding (like Punicode or so), 
but in my simplest case replacing line 306 does the work for me:
--if (sLastGroup == null || _fnGetCleanedGroup(sGroup) != 
_fnGetCleanedGroup(sLastGroup)) {
++if (sLastGroup == null || sGroup != sLastGroup) {

Original comment by dachs...@gmail.com on 19 Apr 2012 at 7:32

GoogleCodeExporter commented 8 years ago
Hi,

Could you please try with the latest version. I have created an example with 
Hebrew letters 
http://jquery-datatables-row-grouping.googlecode.com/svn/trunk/support/issue23.h
tml

Regards,
Jovan

Original comment by joc...@gmail.com on 13 Jul 2012 at 1:53

GoogleCodeExporter commented 8 years ago
Thank you. It works for me (tested in Chrome+IE+FF)

Original comment by dachs...@gmail.com on 16 Jul 2012 at 8:51