search

LiquidFenrir / MultiUpdater

or µpdtr for short, is an updater for 3ds applications/a9lh/b9s payloads rewritten in C++
MIT License
140 stars 18 forks source link

httpcGetDownloadSizeState isn't safe to use #2

Closed ksanislo closed 7 years ago

ksanislo commented 8 years ago

This call will return a size of 0 even if there's data, in the case of Transfer-Encoding: chunked, or other CGI type responses... Look at the patch I submitted to lpp-3ds for a similar issue and how it avoid it by looping over httpcDownloadData() until finished instead.

LiquidFenrir commented 8 years ago

Thanks! I restarted working on the project, and this will be added soon!

ksanislo commented 8 years ago

Cool, just fwiw the 3ds-example for http has been updated to be a better example if you want a clean reference.

LiquidFenrir commented 8 years ago

Thanks for telling me that, I'll take a look at it.

Hikari-chan commented 7 years ago

I fixed this in a new branch, httpc_overhaul. It should be merged to master soon, after a bit more testing.