search

LiquidPlayer / LiquidCore

Node.js virtual machine for Android and iOS
MIT License
1.01k stars 127 forks source link

Is it possible to build the library for node 10 instead of node 8.9.3? #88

Closed stlpedro closed 4 years ago

stlpedro commented 5 years ago

Hi there,

Thank you so much for this great library. I wanted to know if it is possible to build it against nodejs 10.15.1 instead of nodejs 8.9.3.

Please let me know.

-Pedro

ericwlange commented 5 years ago

Yes, but it will take some work. It is not simple to do. It is on my backlog to upgrade to v10.x. Do you mind me asking, what features are in v10 that you are looking for?

stlpedro commented 5 years ago

The error handling…. functions like process.setUncaughtExceptionCaptureCallback and such.

While on the subject of error handling… is there a way to turn on verbose errors reporting? I have a lot of crashes with no errors at all.

-Pedro

From: Eric Lange notifications@github.com Reply-To: LiquidPlayer/LiquidCore reply@reply.github.com Date: Thursday, February 28, 2019 at 10:50 PM To: LiquidPlayer/LiquidCore LiquidCore@noreply.github.com Cc: Pedro Naranjo pedro@stlteks.com, Author author@noreply.github.com Subject: Re: [LiquidPlayer/LiquidCore] Is it possible to build the library for node 10 instead of node 8.9.3? (#88)

Yes, but it will take some work. It is not simple to do. It is on my backlog to upgrade to v10.x. Do you mind me asking, what features are in v10 that you are looking for?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/LiquidPlayer/LiquidCore/issues/88#issuecomment-468562837, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ARImLIvQpJbKgdPO7qEY4P8r_YS8kkZiks5vSM2YgaJpZM4bTdnh.

ericwlange commented 5 years ago

What do you get from process.setUncaughtExceptionCaptureCallback that you don't get from process.on('uncaughtException', callback)? Just curious, because I've always used that.

What kinds of crashes are you getting? Is it Android or iOS? I am surprised it possible to crash without getting anything in the logs. There will be a stack trace in Dalvik (if you are on Android), even if it is cryptic. Is it actually "crashing" (as in you get a page fault or something) or is the process just exiting, albeit unexpectedly?

ericwlange commented 4 years ago

0.7.x now uses 10.15.3