search

LiquidPlayer / liquidcore-cli

Command line interface for LiquidCore
MIT License
3 stars 0 forks source link

react-native 0.56 dependency broken on Windows, possible upgrade to 0.58? #2

Open KG204 opened 5 years ago

KG204 commented 5 years ago

I'm trying to integrate a library that uses websocket communication, and I've been running into issues integrating it with LiquidCore-Cli.

Specifically, I get a AccessibilityInfo is not found in Haste module. I think it's related to this bug here: https://github.com/facebook/react-native/issues/19953 Which seems to have been resolved in earlier and later versions of react-native, just broken on 0.56 on Windows.

KG204 commented 5 years ago

Specifically referring to init.js script

ericwlange commented 5 years ago

Metro can be extremely frustrating ...

Upgrading react-native is a little bit more involved than it may seem for two reasons:

  1. There was a major upgrade in metro from 0.56 -> 0.57, so I am pretty sure everything would break by just changing the dependency version
  2. 0.56 was chosen because that was the state-of-the-art version when I created ReactNativeSurface. That project is strictly dependent on 0.56, and upgrading may be a large undertaking that I'm not ready to do yet (it was a lot of work to get it to work in the first place)

I will upgrade eventually, but I am not sure it will work with your timeframe.

I don't have a Windows machine unfortunately so I can't debug this, but have you tried simple/obvious hacks like creating a file called AccessibilityInfo.js and throwing it in node_modules?

KG204 commented 5 years ago

From the link above, it's not so much about AcessibilityInfo, it's just the first one in a list of dependencies that are tried to resolve.

I will set up a VM with Linux to test 0.56.0 to see if I can use that for bundling,

ericwlange commented 5 years ago

Others have had success just using webpack instead of metro -- you could see if that works also.