search

LiquidZulu / liquidzulu.github.io

Creative Commons Zero v1.0 Universal
3 stars 2 forks source link

Images fail to embed if using a space in the image file name #138

Open LiquidZulu opened 6 months ago

LiquidZulu commented 6 months ago

If an image has a url like /path/to/some image.png "alt text") then it fails to be turned into an actual <img> tag. I have written a remark plugin that properly URI encodes these paths with this commit, but it is not being applied properly. I can see that it is indeed correctly mapping ![img](/path/to/some image.png "alt text) -> ![img](/path/to/some image.png "alt text") but it is still showing raw markdown, as against embedding that valid image.

I do not know why it is that the aforementioned plugin does not work, but I suspect that it is being applied after the images have already been embedded, but I do not know. Maybe I need to change the type from text to image 🤔.

LiquidZulu commented 5 months ago

I can see that it is indeed correctly mapping ![img](/path/to/some image.png "alt text) -> ![img](/path/to/some image.png "alt text")

What is bro yapping about?