search

Liquipedia / Lua-Modules

Used to keep versions of some important lua modules of the Liquipedia wiki that we want better version control for.
Other
31 stars 69 forks source link

Additional Parameter Support for NotabilityChecker #1879

Closed DMeluca closed 2 weeks ago

DMeluca commented 2 years ago

The call to the wiki specific dropoff function in the NotabilityChecker currently only supports placement and tier/tiertype as the deciding factors for the returned score.

However, Apex uses the region in which the tournament was played as a deciding factor to introduce another factor that affects the notability score

notab

The local prizepool has been updated to include this information in lpdb.placement.extradata. Could an additional argument of "placement.extradata.notabilitymod" be passed to allow wikis more customization in the handling of wiki specific drop off function? The below line is the first call where it would need implemented, but this argument would then need passed again to reach the code block that calls the "Config.placementDropOffFunction" function

local weight = NotabilityChecker.calculateTournament( placement.liquipediatier, placement.liquipediatiertype, placement.placement, placement.date, placement.extradata.notabilitymod, placement.mode )

https://liquipedia.net/commons/index.php?title=Module:NotabilityChecker&action=edit#mw-ce-l141

mbergen commented 2 years ago

IMO just pass all of the extradata there instead of enforcing a specific field name.

DMeluca commented 2 years ago

An example of what it would look like implemented can be seen on the dev module on apexlegends here https://liquipedia.net/apexlegends/Module:NotabilityChecker/dev