PrizePool should recognise variables to prevent SMW/LPDB storage

[mbergen]

Old prize pools recognised variables like disable_SMW_storage or mute_smw to prevent storage from happening, e.g. when transcluding prize pool sections on another page. The PPT now can only disable storage by direct argument: https://github.com/Liquipedia/Lua-Modules/blob/e234ad985c5bcd83c247d3317d2a06862b3a8de1/components/prize_pool/commons/prize_pool.lua#L90-L100

There should be the possibility to rely on such variables again.

• What is the "standardised" naming scheme for these variables?
  • disable_LPDB_storage, disable_SMW_storage

Legacy PPT/Old prize pools that used this behaviour:

• brawlstars (disable_SMW_storage)
• dota2 (disable_SMW_storage or smw mute)
• valorant (disable_SMW_storage or smw mute)
• counterstrike (disable_SMW_storage)
• pubgmobile (disable_SMW_storage)
• leagueoflegends (disable_SMW_storage)
• apexlegends (disable_SMW_storage)
• rainbowsix (disable_SMW_storage)
• overwatch (disable_SMW_storage)
• mobilelegends (disable_SMW_storage)
• pubg (disable_SMW_storage)
• ageofempires (smw mute)
• wildrift (disable_SMW_storage)
• warcraft (smw mute)
• arenaofvalor (smw mute)
• trackmania (disable_SMW_storage)
• Pokemon (smw mute)
• simracing (disable_SMW_storage)

Not used/Unsure:

• rocketleague - sets disable_SMW_storage in start, but does not recognize in row (only uses argument smw mute)
• sc/sc2
• fifa
• clashroyale
• crossfire

[hjpalpha]

What is the "standardised" naming scheme for these variables?

https://liquipedia.net/commons/index.php?title=Template:SMW_storage&action=edit (the lpdb one is what we would want in the future as we kick smw but for now if we add it check for both (or))

[hjpalpha]

imo check if all old prize pools did it that way there might be some that did not and for those wikis adding it would be a breaking change

[mbergen]

imo check if all old prize pools did it that way there might be some that did not and for those wikis adding it would be a breaking change

Updated issue with a list of all wikis using PPT Legacy. IMO it's fine to add this behaviour for commons PPT, we could add a tracking category to be checked on the wikis previously not supporting it to take a look whether there would be affected pages.

[hjpalpha]

imo check if all old prize pools did it that way there might be some that did not and for those wikis adding it would be a breaking change

Updated issue with a list of all wikis using PPT Legacy. IMO it's fine to add this behaviour for commons PPT, we could add a tracking category to be checked on the wikis previously not supporting it to take a look whether there would be affected pages.

for the 2nd list "Not used/Unsure" from looking at insource search (insource:disable) and usage of the above linked template:

• sc/sc2: okay to change
• clashroyale: okay to change (template unused)
• fifa: okay to change (template unused)
• crossfire: okay to change (template unused)
• rocketleague: okay to change (template unused in main space)

usage of the var is usually right before transclusions of results sections (often even "deactivated" right after it again)

[mbergen]

Old templates often used just disable_SMW_storage to cutoff both SMW and LPDB. Do we want to continue with that, or separate this?

[hjpalpha]

Old templates often used just disable_SMW_storage to cutoff both SMW and LPDB. Do we want to continue with that, or separate this?

imo we eventually should bot stuff from disable_SMW_storage manually set variable to the according template and also only look at disable_LPDB_storage (since soonish smw gets killed anyways)

[hjpalpha]

FYI: bot job to standardize the variable (and use the template instead of setting it manually) is under way

i would suggest to wait with a pr for this until the refactor of pot is done (the one (2prs) that splits stuff so that we can standardize awards)

[hjpalpha]

bot runs done the ppt split prs are also merged so from me gogo here^^