search

Liquipedia / Lua-Modules

Used to keep versions of some important lua modules of the Liquipedia wiki that we want better version control for.
Other
31 stars 67 forks source link

Tier Data Modules #2670

Closed hjpalpha closed 1 year ago

hjpalpha commented 1 year ago

code smiped to check stuff

{{#invoke:Tier/cleanup|find}}
{{#invoke:Tier/cleanup|findPagesByTier|tiers=Misc}}
{{#invoke:Tier/cleanup|findPagesByTierType|types=Misc}}

tier data modules still to do

PRs

Using Legacy stuff (tierTypes as tiers)

mbergen commented 1 year ago

FTR about AoE: Will take some more time. Editors aren't happy with the proposed change to change the current Showmatch tier to a tiertype, as it is not really possible to determine meaningful tiers for showmatches. I'm currently trying to get feedback whether a Misc/-1 tier would be accepted (Misc is currently a tiertype and would need to be changed). Is there any context on why -1/Misc would be allowed as tier, but Showmatch wouldn't?

hjpalpha commented 1 year ago

FTR about AoE: Will take some more time.

CS tier conversion will take at least a week anyways before that i do not want the infoboxes etc adjusted anyways

Editors aren't happy with the proposed change to change the current Showmatch tier to a tiertype, as it is not really possible to determine meaningful tiers for showmatches. I'm currently trying to get feedback whether a Misc/-1 tier would be accepted (Misc is currently a tiertype and would need to be changed). Is there any context on why -1/Misc would be allowed as tier, but Showmatch wouldn't?

from my understanding misc/-1 would symbolize the lack of a tier or the case that it is not possible to asign a tier with the normal criteria so imo a perfect fit for your former showmatches where a tier (1-4) can not be assigned

mbergen commented 1 year ago

AoE: Showmatches are converted to use Misc Tier. A question that remains: Is it possible to use Misc both as tiertype and tier? I've seen it setup like this in the RL Tier/Data.

hjpalpha commented 1 year ago

A question that remains: Is it possible to use Misc both as tiertype and tier?

not a fan of it but that would be something @Rathoz has to decide

I've seen it setup like this in the RL Tier/Data.

that was a mistake on my part

Rathoz commented 1 year ago

Agreed that it would be better to have one or the other. I think having it as both would just cause confusion for the end user

mbergen commented 1 year ago

I've wrote it to hjp earlier, FYI Rath: The issue we have on AoE that there are tournaments were usual tiers can be applied, but we used to denote them as Misc if something didn't fall into the usual game style, e.g. FFA/Dodgeball (some kind of minigame so to say), or recently, Xbox/Controller-only tournaments. While it's fine for the former to just be Misc now, or Tier+FFA type, it's a bit of a tricky situation now: We can't use Xbox/Controller as tiertype, as then we couldn't mark something as showmatch. That's a thing were a misc type would be handy. It also isn't really possible to solve this by denoting Xbox as another game, cause it isn't, and there even is cross play, although no tournaments yet.

Rathoz commented 1 year ago

So what most other wikis do with "non-standard game style" is having the tournament tier as Misc, due to determining the level of play (Tier) in a "meme" mode is not realistic (eg having A-Tier players playing Dodgeball, wouldn't make the competition an A-Tier level tournament (that's my opinion at least)).

I'm not sure I correctly understand the case when you needed Misc as a TierType? Could you rephrase it, or provide an example?

mbergen commented 1 year ago

Since i've now introduced a tiertype for FFA tournaments, these are solved, and Dodgeball is fine as Misc tier. What is left are controller-only tournaments: Until yesterday, these had Tiers, but tiertype misc, as the level is way lower compared to classic keyboard/mouse (might be due to it only being a thing since 31st January). So while we could add another tiertype Controller for this, then how would we mark a controller showmatch?

Rathoz commented 1 year ago

Wouldn't it be more fair to add them as the lowest tier tournament, alternative create D-Tier and have the controller matches as that? It might get competitive with KBM tournaments, and you said there might be crossplay tournaments?

mbergen commented 1 year ago

Seems like a fair solution, will bring this up to the other editors.